👌 IMPROVE: Remove unnecessary script dependencies.#56
Closed
TimothyBJacobs wants to merge 1 commit into
Closed
Conversation
These dependencies aren't necessary. The `wp-blocks` style previously held the styles for core blocks, which the built styles do not depend on. It was also removed in the latest Gutenberg version. The editor dependencies are always enqueued before the editor assets. Fixes #55
ajitbohra
reviewed
May 19, 2018
| wp_enqueue_script( | ||
| '<% blockNamePHPLower %>-cgb-block-js', // Handle. | ||
| plugins_url( '/dist/blocks.build.js', dirname( __FILE__ ) ), // Block.build.js: We register the block here. Built with Webpack. | ||
| array( 'wp-blocks', 'wp-i18n', 'wp-element' ), // Dependencies, defined above. |
There was a problem hiding this comment.
These dependencies are required:
wp-blockshandles block registration & various other block API'swp-i18nhandles translationswp-elementreact createElement abstraction
This was referenced May 19, 2018
ahmadawais
requested changes
May 27, 2018
Member
ahmadawais
left a comment
ahmadawais
left a comment
There was a problem hiding this comment.
Take a look at @ajitbohra's comment. I seem to agree with him that certain dependencies are still required.
ahmadawais
changed the title
Member
|
This was fixed in #110 |
Member
|
Thank You! 😇for the contributions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These dependencies aren't necessary. The
wp-blocksstyle previously held the styles for core blocks, which the built styles do not depend on. It was also removed in the latest Gutenberg version.The editor dependencies are always enqueued before the editor assets.
Fixes ahmadawais/create-guten-block#64